Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/telemetry/telemetry/results/results_options.py

Issue 440243002: Unittest for page_runner, etc. should suppress output from gtest_progress_reporter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/progress_reporter.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/results_options.py
diff --git a/tools/telemetry/telemetry/results/results_options.py b/tools/telemetry/telemetry/results/results_options.py
index 1d330cfb69455b5ac2af7d21fefdc10887858aa1..c8b95e5ac62fec2993d81eff3141908821d3fa18 100644
--- a/tools/telemetry/telemetry/results/results_options.py
+++ b/tools/telemetry/telemetry/results/results_options.py
@@ -13,6 +13,7 @@ from telemetry.results import gtest_progress_reporter
from telemetry.results import html_output_formatter
from telemetry.results import json_output_formatter
from telemetry.results import page_test_results
+from telemetry.results import progress_reporter
# Allowed output formats. The default is the first item in the list.
@@ -40,10 +41,17 @@ def AddResultsOptions(parser):
group.add_option('--results-label',
default=None,
help='Optional label to use for the results of a run .')
+ group.add_option('--suppress_gtest_report',
+ default=False,
+ help='Whether to suppress GTest progress report.')
parser.add_option_group(group)
def CreateResults(metadata, options):
+ """
+ Args:
+ options: Contains the options specified in AddResultsOptions.
+ """
# TODO(chrishenry): This logic prevents us from having multiple
# OutputFormatters. We should have an output_file per OutputFormatter.
# Maybe we should have --output-dir instead of --output-file?
@@ -63,6 +71,7 @@ def CreateResults(metadata, options):
output_formatters = []
output_skipped_tests_summary = True
+ reporter = None
if options.output_format == 'none':
pass
elif options.output_format == 'csv':
@@ -97,7 +106,10 @@ def CreateResults(metadata, options):
% (options.output_format,
', '.join(_OUTPUT_FORMAT_CHOICES)))
- reporter = gtest_progress_reporter.GTestProgressReporter(
- sys.stdout, output_skipped_tests_summary=output_skipped_tests_summary)
+ if options.suppress_gtest_report:
+ reporter = progress_reporter.ProgressReporter()
+ else:
+ reporter = gtest_progress_reporter.GTestProgressReporter(
+ sys.stdout, output_skipped_tests_summary=output_skipped_tests_summary)
return page_test_results.PageTestResults(
output_formatters=output_formatters, progress_reporter=reporter)
« no previous file with comments | « tools/telemetry/telemetry/results/progress_reporter.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698