Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 440003: gtk: Restore omnibox text selection on tab switch. (Closed)

Created:
11 years, 1 month ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
James Su, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gtk: Restore omnibox text selection on tab switch. Tested by: - highlighting omnibox text - switching to a different tab - highlighting some other text - switching back to the first tab - confirming that the omnibox highlighting was restored but PRIMARY didn't get updated when switching back BUG=20674 TEST=see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32914

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
11 years, 1 month ago (2009-11-24 01:28:29 UTC) #1
Evan Martin
LGTM, do you think it breaks anything else? http://codereview.chromium.org/440003/diff/1/3 File chrome/browser/autocomplete/autocomplete_edit_view_gtk.h (left): http://codereview.chromium.org/440003/diff/1/3#oldcode192 chrome/browser/autocomplete/autocomplete_edit_view_gtk.h:192: gboolean ...
11 years, 1 month ago (2009-11-24 01:30:14 UTC) #2
Daniel Erat
On Mon, Nov 23, 2009 at 5:30 PM, <evan@chromium.org> wrote: > LGTM, do you think ...
11 years, 1 month ago (2009-11-24 01:33:30 UTC) #3
James Su
11 years, 1 month ago (2009-11-24 01:34:00 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698