gtk: Restore omnibox text selection on tab switch.

chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit_view_gtk.h"
 
 #include <gtk/gtk.h>
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
@@ skipping 313 matching lines @@
 
   if (contents) {
     selected_text_.clear();
     RevertAll();
     const AutocompleteEditState* state =
         GetStateAccessor()->GetProperty(contents->property_bag());
     if (state) {
       model_->RestoreState(state->model_state);
 
       // Move the marks for the cursor and the other end of the selection to
-      // the previously-saved offsets.
-      GtkTextIter selection_iter, insert_iter;
-      ItersFromCharRange(
-          state->view_state.selection_range, &selection_iter, &insert_iter);
-      // TODO(derat): Restore the selection range instead of just the cursor
-      // ("insert") position.  This in itself is trivial to do using
-      // gtk_text_buffer_select_range(), but then it also becomes necessary to
-      // invalidate hidden tabs' saved ranges when another tab or another app
-      // takes the selection, lest we incorrectly regrab a stale selection when
-      // a hidden tab is later shown.
-      gtk_text_buffer_place_cursor(text_buffer_, &insert_iter);
+      // the previously-saved offsets (but preserve PRIMARY).
+      StartUpdatingHighlightedText();
+      SetSelectedRange(state->view_state.selection_range);
+      FinishUpdatingHighlightedText();
     }
   } else if (visibly_changed_permanent_text) {
     RevertAll();
     // TODO(deanm): There should be code to restore select all here.
   } else if (changed_security_level) {
     EmphasizeURLComponents();
   }
 }
 
 void AutocompleteEditViewGtk::OpenURL(const GURL& url,
@@ skipping 961 matching lines @@
   std::string utf8 = WideToUTF8(text);
   gtk_text_buffer_set_text(text_buffer_, utf8.data(), utf8.length());
   SetSelectedRange(range);
 }
 
 void AutocompleteEditViewGtk::SetSelectedRange(const CharRange& range) {
   GtkTextIter insert, bound;
   ItersFromCharRange(range, &bound, &insert);
   gtk_text_buffer_select_range(text_buffer_, &insert, &bound);
 }