Issue 43993002: Experimental scanner: More fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43993002: Experimental scanner: More fixes. (Closed)

Created:
7 years, 2 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental scanner: More fixes. Failures now down to 9 (from 16). "marker_" was unused; using it for the purpose of going back to a defined point in the character stream. E.g., if we're parsing "\illegalstuff\22222" and notice a "\" after the number. At this point we need to push 22222 as ILLEGAL, so we need to know where it started. TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17395

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	src/lexer/lexer.re	View		4 chunks	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

marja

7 years, 2 months ago (2013-10-25 11:57:30 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r17395 (presubmit successful).

Expand Messages | Collapse Messages