Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 439643003: Change AboutResourceLoader::GetAboutResource to wait for inflight update task. (Closed)

Created:
6 years, 4 months ago by kinaba
Modified:
6 years, 4 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Change AboutResourceLoader::GetAboutResource to wait for inflight update task. This is a preparation for Bug 329732. The actual fix for the bug will come in the next separate patch. The current changes forces GetAboutResource to wait for the result of running UpdateAboutResource task if any. BUG=329732 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287427

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -32 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.h View 1 chunk +20 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 3 chunks +34 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinaba
PTAL. Next patch upon this one will start calling UpdateAboutResource() for each CheckForUpdates, and the ...
6 years, 4 months ago (2014-08-04 08:08:44 UTC) #1
hashimoto
lgtm
6 years, 4 months ago (2014-08-04 08:28:34 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 4 months ago (2014-08-04 08:29:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/439643003/40001
6 years, 4 months ago (2014-08-04 08:29:49 UTC) #4
kinaba
The CQ bit was unchecked by kinaba@chromium.org
6 years, 4 months ago (2014-08-04 08:38:05 UTC) #5
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 4 months ago (2014-08-04 23:25:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/439643003/80001
6 years, 4 months ago (2014-08-04 23:25:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 00:37:49 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 01:05:53 UTC) #9
Message was sent while issue was closed.
Change committed as 287427

Powered by Google App Engine
This is Rietveld 408576698