Change AboutResourceLoader::GetAboutResource to wait for inflight update task.

chrome/browser/chromeos/drive/change_list_loader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_DRIVE_CHANGE_LIST_LOADER_H_
 #define CHROME_BROWSER_CHROMEOS_DRIVE_CHANGE_LIST_LOADER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 67 matching lines @@
  public:
   explicit AboutResourceLoader(JobScheduler* scheduler);
   ~AboutResourceLoader();
 
   // Returns the cached about resource.
   // NULL is returned if the cache is not available.
   const google_apis::AboutResource* cached_about_resource() const {
     return cached_about_resource_.get();
   }
 
-  // Gets the about resource from the cache or the server. If the cache is
-  // availlavle, just runs |callback| with the cached about resource. If not,
-  // calls |UpdateAboutResource| passing |callback|.
+  // Gets the 'latest' about resource and asynchronously runs |callback|. I.e.,
+  // 1) If the last call to UpdateAboutResource call is in-flight, wait for it.
+  // 2) Otherwise, if the resource is cached, just returns the cached value.
+  // 3) If neither of the above hold, queries the API server by calling
+  //   |UpdateAboutResource|.
   void GetAboutResource(const google_apis::AboutResourceCallback& callback);
 
   // Gets the about resource from the server, and caches it if successful. This
   // function calls JobScheduler::GetAboutResource internally. The cache will be
   // used in |GetAboutResource|.
-  void UpdateAboutResource(
-      const google_apis::AboutResourceCallback& callback);
+  void UpdateAboutResource(const google_apis::AboutResourceCallback& callback);
 
  private:
   // Part of UpdateAboutResource().
   // This function should be called when the latest about resource is being
-  // fetched from the server. The retrieved about resoure is cloned, and one is
-  // cached and the other is passed to |callback|.
+  // fetched from the server. The retrieved about resource is cloned, and one is
+  // cached and the other is passed to callbacks associated with |task_id|.
   void UpdateAboutResourceAfterGetAbout(
-      const google_apis::AboutResourceCallback& callback,
+      int task_id,
       google_apis::GDataErrorCode status,
       scoped_ptr<google_apis::AboutResource> about_resource);
 
   JobScheduler* scheduler_;
   scoped_ptr<google_apis::AboutResource> cached_about_resource_;
+
+  // Identifier to denote the latest UpdateAboutResource call.
+  int current_update_task_id_;
+  // Mapping from each UpdateAboutResource task ID to the corresponding
+  // callbacks. Note that there will be multiple callbacks for a single task
+  // when GetAboutResource is called before the task completes.
+  std::map<int, std::vector<google_apis::AboutResourceCallback> >
+      pending_callbacks_;
+
   base::WeakPtrFactory<AboutResourceLoader> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(AboutResourceLoader);
 };
 
 // ChangeListLoader is used to load the change list, the full resource list,
-// and directory contents, from WAPI (codename for Documents List API)
-// or Google Drive API.  The class also updates the resource metadata with
-// the change list loaded from the server.
+// and directory contents, from Google Drive API.  The class also updates the
+// resource metadata with the change list loaded from the server.
 //
 // Note that the difference between "resource list" and "change list" is
 // subtle hence the two words are often used interchangeably. To be precise,
 // "resource list" refers to metadata from the server when fetching the full
 // resource metadata, or fetching directory contents, whereas "change list"
 // refers to metadata from the server when fetching changes (delta).
 class ChangeListLoader {
  public:
   // Resource feed fetcher from the server.
   class FeedFetcher;
@@ skipping 89 matching lines @@
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<ChangeListLoader> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(ChangeListLoader);
 };
 
 }  // namespace internal
 }  // namespace drive
 
 #endif  // CHROME_BROWSER_CHROMEOS_DRIVE_CHANGE_LIST_LOADER_H_