tools/telemetry/telemetry/value/string_unittest.py - Issue 439613003: Add Chart JSON processing to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/string_unittest.py

Issue 439613003: Add Chart JSON processing to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most of Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/string_unittest.py

diff --git a/tools/telemetry/telemetry/value/string_unittest.py b/tools/telemetry/telemetry/value/string_unittest.py

index b8cc2a386e532ca9ae696ef933dd54910da3818f..05890dfe96b520f97e27868d58b1471333bb5bf5 100644

--- a/tools/telemetry/telemetry/value/string_unittest.py

+++ b/tools/telemetry/telemetry/value/string_unittest.py

@@ -27,7 +27,7 @@ class StringValueTest(TestBase):

value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT))

self.assertEquals(['L1'], v.GetBuildbotValue())

self.assertEquals(('x', page0.display_name),

- v.GetBuildbotMeasurementAndTraceNameForPerPageResult())

+ v.GetChartAndTraceNameForPerPageResult())

v = string.StringValue(page0, 'x', 'label', 'L1', important=False)

self.assertEquals(