Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: tools/telemetry/telemetry/value/string_unittest.py

Issue 439613003: Add Chart JSON processing to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address most of Nat's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import unittest 5 import unittest
6 6
7 from telemetry import value 7 from telemetry import value
8 from telemetry.page import page_set 8 from telemetry.page import page_set
9 from telemetry.value import string 9 from telemetry.value import string
10 10
11 class TestBase(unittest.TestCase): 11 class TestBase(unittest.TestCase):
12 def setUp(self): 12 def setUp(self):
13 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 13 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
14 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/") 14 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
15 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/") 15 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
16 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/") 16 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
17 17
18 @property 18 @property
19 def pages(self): 19 def pages(self):
20 return self.page_set.pages 20 return self.page_set.pages
21 21
22 class StringValueTest(TestBase): 22 class StringValueTest(TestBase):
23 def testBuildbotValueType(self): 23 def testBuildbotValueType(self):
24 page0 = self.pages[0] 24 page0 = self.pages[0]
25 v = string.StringValue(page0, 'x', 'label', 'L1', important=True) 25 v = string.StringValue(page0, 'x', 'label', 'L1', important=True)
26 self.assertEquals('default', v.GetBuildbotDataType( 26 self.assertEquals('default', v.GetBuildbotDataType(
27 value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT)) 27 value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT))
28 self.assertEquals(['L1'], v.GetBuildbotValue()) 28 self.assertEquals(['L1'], v.GetBuildbotValue())
29 self.assertEquals(('x', page0.display_name), 29 self.assertEquals(('x', page0.display_name),
30 v.GetBuildbotMeasurementAndTraceNameForPerPageResult()) 30 v.GetChartAndTraceNameForPerPageResult())
31 31
32 v = string.StringValue(page0, 'x', 'label', 'L1', important=False) 32 v = string.StringValue(page0, 'x', 'label', 'L1', important=False)
33 self.assertEquals( 33 self.assertEquals(
34 'unimportant', 34 'unimportant',
35 v.GetBuildbotDataType(value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT)) 35 v.GetBuildbotDataType(value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT))
36 36
37 def testStringSamePageMerging(self): 37 def testStringSamePageMerging(self):
38 page0 = self.pages[0] 38 page0 = self.pages[0]
39 v0 = string.StringValue(page0, 'x', 'label', 'L1') 39 v0 = string.StringValue(page0, 'x', 'label', 'L1')
40 v1 = string.StringValue(page0, 'x', 'label', 'L2') 40 v1 = string.StringValue(page0, 'x', 'label', 'L2')
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 'type': 'string', 73 'type': 'string',
74 'name': 'x', 74 'name': 'x',
75 'units': 'unit', 75 'units': 'unit',
76 'value': 'foo' 76 'value': 'foo'
77 } 77 }
78 78
79 v = value.Value.FromDict(d, {}) 79 v = value.Value.FromDict(d, {})
80 80
81 self.assertTrue(isinstance(v, string.StringValue)) 81 self.assertTrue(isinstance(v, string.StringValue))
82 self.assertEquals(v.value, 'foo') 82 self.assertEquals(v.value, 'foo')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698