tools/telemetry/telemetry/results/json_output_formatter_unittest.py - Issue 439613003: Add Chart JSON processing to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/json_output_formatter_unittest.py

Issue 439613003: Add Chart JSON processing to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most of Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/results/json_output_formatter.py ('K') | « tools/telemetry/telemetry/results/json_output_formatter.py ('k') | tools/telemetry/telemetry/results/results_options.py » ('j') | tools/telemetry/telemetry/results/results_options.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/json_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

index 0a40432f0119b06dcec12bdf293379ce806b082e..74fb47e19596b15f0f97ba42b51db02de8d49313 100644

--- a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py

@@ -45,6 +45,13 @@ class JsonOutputFormatterTest(unittest.TestCase):

self._formatter.Format(results)

json.loads(self._output.getvalue())

+ def testAsDictBaseKeys(self):

+ results = page_test_results.PageTestResults()

+ d = json_output_formatter.ResultsAsDict(results, self._formatter.metadata)

+ self.assertEquals(d['format_version'], '0.2')

+ self.assertEquals(d['test_name'], 'test_name')

def testAsDictWithOnePage(self):

results = page_test_results.PageTestResults()

results.WillRunPage(self._page_set[0])