tools/telemetry/telemetry/results/json_output_formatter.py - Issue 439613003: Add Chart JSON processing to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/json_output_formatter.py

Issue 439613003: Add Chart JSON processing to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address most of Nat's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/results/json_output_formatter.py

diff --git a/tools/telemetry/telemetry/results/json_output_formatter.py b/tools/telemetry/telemetry/results/json_output_formatter.py

index e3ccb1fc7b7d8ae9034166d379016ab0d22ae1c9..43b0abd9afc8c18b91cbb83f15dfb35d8d87638e 100644

--- a/tools/telemetry/telemetry/results/json_output_formatter.py

+++ b/tools/telemetry/telemetry/results/json_output_formatter.py

@@ -9,7 +9,7 @@ from telemetry.results import output_formatter

def ResultsAsDict(page_test_results, metadata):

chrishenry - DO NOT USE 2014/08/13 05:12:01 metadata is very confusing. Can you rename this an

eakuefner 2014/08/15 22:47:31 Done.

result_dict = {

'format_version': '0.2',

- 'benchmark_name': metadata.name,

+ 'test_name': metadata.name,

chrishenry - DO NOT USE 2014/08/13 05:12:01 metadata is always a BenchmarkMetadata anyway, so

eakuefner 2014/08/15 22:47:31 Done.

'summary_values': [v.AsDict() for v in

page_test_results.all_summary_values],

'per_page_values': [v.AsDict() for v in