Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 4396001: Merge 64807 & 64824 - Cloud Print Dialog work (Closed)

Created:
10 years, 1 month ago by Scott Byer
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, tim (not reviewing), ncarter (slow), nkostylev+cc_chromium.org, ben+cc_chromium.org, Sergey Ulanov, Raghu Simha, Alpha Left Google, idana, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 64807 - Minimum UI change for Cloud Print dialog. Minimum change to remove the title and get the initial dialog size correct. Still has gobs of whitespace at the top. Merge 64824 - Cloud Print Dialog work (extends 64807) Allow an HTML dialog to suppress the title bar in a Chromium OS bubble window. For the Cloud Print dialog, remember the last size requested by the contents. Bug Url: http://code.google.com/p/chromium-os/issues/detail?id=8494 BUG=chromium-os:8494 TEST=none Review URL for 64807: http://codereview.chromium.org/4146015 Review URL for 64824: http://codereview.chromium.org/4110010 TBR=scottbyer@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browser_signin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 3 chunks +29 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/html_dialog_ui.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/html_dialog_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 8 chunks +38 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/remoting_setup_flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/remoting/remoting_setup_flow.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/html_dialog_view.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/views/html_dialog_view.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/views/html_dialog_view_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/select_file_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Byer
CrOS targeted change, no effect for other platforms. Combined dependent merges and resolved conflicts in ...
10 years, 1 month ago (2010-11-03 19:18:58 UTC) #1
Scott Byer
Do you want to double-check the merge patch, or should I submit it TBR (or ...
10 years, 1 month ago (2010-11-03 21:52:38 UTC) #2
zel
10 years, 1 month ago (2010-11-03 21:58:05 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698