Issue 4146015: Minimum UI change for Cloud Print dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4146015: Minimum UI change for Cloud Print dialog. (Closed)

Created:
10 years, 1 month ago by Scott Byer

Modified:
9 years, 7 months ago

Reviewers:
sanjeevr

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Minimum UI change for Cloud Print dialog. Minimum change to remove the title and get the initial dialog size correct. Still has gobs of whitespace at the top. BUG=chromium-os:8494 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64807

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/printing/print_dialog_cloud.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/printing/print_dialog_cloud_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Scott Byer

This is the alternate trivial fix up that leavs large amounts of whitespace in the ...

10 years, 1 month ago (2010-11-01 23:44:39 UTC) #1

LGTM