Issue 439273007: Don't compare constant color and coverage between GrDrawStates when they are provided by vertex att…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 439273007: Don't compare constant color and coverage between GrDrawStates when they are provided by vertex att… (Closed)

Created:
6 years, 4 months ago by bsalomon

Modified:
6 years, 4 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@compat

Visibility:
Public.

Don't compare constant color and coverage between GrDrawStates when they are provided by vertex attributes. Committed: https://skia.googlesource.com/skia/+/72336ed7e16d2672543e0ceca9ddb843c63c8df6

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -48 lines)			Patch
M	src/gpu/GrBitmapTextContext.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1	3 chunks	+10 lines, -34 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

bsalomon

This is slightly overlapping with the work you're doing around GrDS optimization. But it is ...

6 years, 4 months ago (2014-08-04 20:41:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/439273007/20001

6 years, 4 months ago (2014-08-05 14:25:55 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-05 14:36:01 UTC) #5

Message was sent while issue was closed.

Change committed as 72336ed7e16d2672543e0ceca9ddb843c63c8df6