Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 439243004: Stop depending on TemplateURLServiceFactory from SearchProvider (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Project:
chromium
Visibility:
Public.

Description

Stop depending on TemplateURLServiceFactory from SearchProvider BUG=388515 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -55 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.h View 5 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 11 chunks +25 lines, -20 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-04 11:57:19 UTC) #1
Peter Kasting
LGTM
6 years, 4 months ago (2014-08-04 21:06:27 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-05 00:32:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/439243004/1
6 years, 4 months ago (2014-08-05 00:33:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 01:43:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 01:50:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1087)
6 years, 4 months ago (2014-08-05 01:50:29 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-05 02:12:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/439243004/1
6 years, 4 months ago (2014-08-05 02:13:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 03:42:40 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 05:33:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1114)
6 years, 4 months ago (2014-08-05 05:33:49 UTC) #12
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-05 05:55:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/439243004/1
6 years, 4 months ago (2014-08-05 05:56:54 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:00:01 UTC) #15
Message was sent while issue was closed.
Change committed as 287487

Powered by Google App Engine
This is Rietveld 408576698