Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 439243004: Stop depending on TemplateURLServiceFactory from SearchProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/zero_suggest_provider.h" 5 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/i18n/case_conversion.h" 8 #include "base/i18n/case_conversion.h"
9 #include "base/json/json_string_value_serializer.h" 9 #include "base/json/json_string_value_serializer.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/prefs/pref_service.h" 11 #include "base/prefs/pref_service.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "base/time/time.h" 15 #include "base/time/time.h"
16 #include "chrome/browser/autocomplete/autocomplete_classifier.h" 16 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
17 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" 17 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
18 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h" 18 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
19 #include "chrome/browser/autocomplete/history_url_provider.h" 19 #include "chrome/browser/autocomplete/history_url_provider.h"
20 #include "chrome/browser/autocomplete/search_provider.h" 20 #include "chrome/browser/autocomplete/search_provider.h"
21 #include "chrome/browser/history/history_types.h" 21 #include "chrome/browser/history/history_types.h"
22 #include "chrome/browser/history/top_sites.h" 22 #include "chrome/browser/history/top_sites.h"
23 #include "chrome/browser/omnibox/omnibox_field_trial.h" 23 #include "chrome/browser/omnibox/omnibox_field_trial.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/browser/search_engines/template_url_service_factory.h"
26 #include "chrome/common/pref_names.h" 25 #include "chrome/common/pref_names.h"
27 #include "chrome/common/url_constants.h"
28 #include "components/autocomplete/autocomplete_input.h" 26 #include "components/autocomplete/autocomplete_input.h"
29 #include "components/autocomplete/autocomplete_match.h" 27 #include "components/autocomplete/autocomplete_match.h"
30 #include "components/autocomplete/autocomplete_provider_listener.h" 28 #include "components/autocomplete/autocomplete_provider_listener.h"
31 #include "components/metrics/proto/omnibox_input_type.pb.h" 29 #include "components/metrics/proto/omnibox_input_type.pb.h"
32 #include "components/pref_registry/pref_registry_syncable.h" 30 #include "components/pref_registry/pref_registry_syncable.h"
33 #include "components/search_engines/template_url_service.h" 31 #include "components/search_engines/template_url_service.h"
34 #include "components/variations/variations_http_header_provider.h" 32 #include "components/variations/variations_http_header_provider.h"
35 #include "content/public/browser/user_metrics.h" 33 #include "content/public/browser/user_metrics.h"
36 #include "net/base/escape.h" 34 #include "net/base/escape.h"
37 #include "net/base/load_flags.h" 35 #include "net/base/load_flags.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 const int kDefaultVerbatimZeroSuggestRelevance = 1300; 67 const int kDefaultVerbatimZeroSuggestRelevance = 1300;
70 68
71 // Relevance value to use if it was not set explicitly by the server. 69 // Relevance value to use if it was not set explicitly by the server.
72 const int kDefaultZeroSuggestRelevance = 100; 70 const int kDefaultZeroSuggestRelevance = 100;
73 71
74 } // namespace 72 } // namespace
75 73
76 // static 74 // static
77 ZeroSuggestProvider* ZeroSuggestProvider::Create( 75 ZeroSuggestProvider* ZeroSuggestProvider::Create(
78 AutocompleteProviderListener* listener, 76 AutocompleteProviderListener* listener,
77 TemplateURLService* template_url_service,
79 Profile* profile) { 78 Profile* profile) {
80 return new ZeroSuggestProvider(listener, profile); 79 return new ZeroSuggestProvider(listener, template_url_service, profile);
81 } 80 }
82 81
83 // static 82 // static
84 void ZeroSuggestProvider::RegisterProfilePrefs( 83 void ZeroSuggestProvider::RegisterProfilePrefs(
85 user_prefs::PrefRegistrySyncable* registry) { 84 user_prefs::PrefRegistrySyncable* registry) {
86 registry->RegisterStringPref( 85 registry->RegisterStringPref(
87 prefs::kZeroSuggestCachedResults, 86 prefs::kZeroSuggestCachedResults,
88 std::string(), 87 std::string(),
89 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 88 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
90 } 89 }
(...skipping 20 matching lines...) Expand all
111 110
112 base::string16 prefix; 111 base::string16 prefix;
113 TemplateURLRef::SearchTermsArgs search_term_args(prefix); 112 TemplateURLRef::SearchTermsArgs search_term_args(prefix);
114 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms( 113 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms(
115 search_term_args, template_url_service_->search_terms_data())); 114 search_term_args, template_url_service_->search_terms_data()));
116 if (!suggest_url.is_valid()) 115 if (!suggest_url.is_valid())
117 return; 116 return;
118 117
119 // No need to send the current page URL in personalized suggest field trial. 118 // No need to send the current page URL in personalized suggest field trial.
120 if (CanSendURL(input.current_url(), suggest_url, default_provider, 119 if (CanSendURL(input.current_url(), suggest_url, default_provider,
121 current_page_classification_, profile_) && 120 current_page_classification_,
121 template_url_service_->search_terms_data(), profile_) &&
122 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) { 122 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) {
123 // Update suggest_url to include the current_page_url. 123 // Update suggest_url to include the current_page_url.
124 search_term_args.current_page_url = current_query_; 124 search_term_args.current_page_url = current_query_;
125 suggest_url = GURL(default_provider->suggestions_url_ref(). 125 suggest_url = GURL(default_provider->suggestions_url_ref().
126 ReplaceSearchTerms( 126 ReplaceSearchTerms(
127 search_term_args, 127 search_term_args,
128 template_url_service_->search_terms_data())); 128 template_url_service_->search_terms_data()));
129 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url, 129 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url,
130 input.current_url())) { 130 input.current_url())) {
131 return; 131 return;
(...skipping 25 matching lines...) Expand all
157 } 157 }
158 158
159 void ZeroSuggestProvider::ModifyProviderInfo( 159 void ZeroSuggestProvider::ModifyProviderInfo(
160 metrics::OmniboxEventProto_ProviderInfo* provider_info) const { 160 metrics::OmniboxEventProto_ProviderInfo* provider_info) const {
161 if (!results_.suggest_results.empty() || !results_.navigation_results.empty()) 161 if (!results_.suggest_results.empty() || !results_.navigation_results.empty())
162 provider_info->set_times_returned_results_in_session(1); 162 provider_info->set_times_returned_results_in_session(1);
163 } 163 }
164 164
165 ZeroSuggestProvider::ZeroSuggestProvider( 165 ZeroSuggestProvider::ZeroSuggestProvider(
166 AutocompleteProviderListener* listener, 166 AutocompleteProviderListener* listener,
167 TemplateURLService* template_url_service,
167 Profile* profile) 168 Profile* profile)
168 : BaseSearchProvider(listener, profile, 169 : BaseSearchProvider(listener, template_url_service, profile,
169 AutocompleteProvider::TYPE_ZERO_SUGGEST), 170 AutocompleteProvider::TYPE_ZERO_SUGGEST),
170 template_url_service_(TemplateURLServiceFactory::GetForProfile(profile)),
171 results_from_cache_(false), 171 results_from_cache_(false),
172 weak_ptr_factory_(this) { 172 weak_ptr_factory_(this) {
173 } 173 }
174 174
175 ZeroSuggestProvider::~ZeroSuggestProvider() { 175 ZeroSuggestProvider::~ZeroSuggestProvider() {
176 } 176 }
177 177
178 bool ZeroSuggestProvider::StoreSuggestionResponse( 178 bool ZeroSuggestProvider::StoreSuggestionResponse(
179 const std::string& json_data, 179 const std::string& json_data,
180 const base::Value& parsed_data) { 180 const base::Value& parsed_data) {
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 int ZeroSuggestProvider::GetVerbatimRelevance() const { 421 int ZeroSuggestProvider::GetVerbatimRelevance() const {
422 return results_.verbatim_relevance >= 0 ? 422 return results_.verbatim_relevance >= 0 ?
423 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance; 423 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance;
424 } 424 }
425 425
426 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL( 426 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL(
427 const GURL& suggest_url, 427 const GURL& suggest_url,
428 const GURL& current_page_url) const { 428 const GURL& current_page_url) const {
429 if (!ZeroSuggestEnabled(suggest_url, 429 if (!ZeroSuggestEnabled(suggest_url,
430 template_url_service_->GetDefaultSearchProvider(), 430 template_url_service_->GetDefaultSearchProvider(),
431 current_page_classification_, profile_)) 431 current_page_classification_,
432 template_url_service_->search_terms_data(), profile_))
432 return false; 433 return false;
433 434
434 // If we cannot send URLs, then only the MostVisited and Personalized 435 // If we cannot send URLs, then only the MostVisited and Personalized
435 // variations can be shown. 436 // variations can be shown.
436 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() && 437 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() &&
437 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) 438 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial())
438 return false; 439 return false;
439 440
440 // Only show zero suggest for HTTP[S] pages. 441 // Only show zero suggest for HTTP[S] pages.
441 // TODO(mariakhomenko): We may be able to expand this set to include pages 442 // TODO(mariakhomenko): We may be able to expand this set to include pages
(...skipping 15 matching lines...) Expand all
457 prefs::kZeroSuggestCachedResults); 458 prefs::kZeroSuggestCachedResults);
458 if (!json_data.empty()) { 459 if (!json_data.empty()) {
459 scoped_ptr<base::Value> data( 460 scoped_ptr<base::Value> data(
460 SearchSuggestionParser::DeserializeJsonData(json_data)); 461 SearchSuggestionParser::DeserializeJsonData(json_data));
461 if (data && ParseSuggestResults(*data.get(), false, &results_)) { 462 if (data && ParseSuggestResults(*data.get(), false, &results_)) {
462 ConvertResultsToAutocompleteMatches(); 463 ConvertResultsToAutocompleteMatches();
463 results_from_cache_ = !matches_.empty(); 464 results_from_cache_ = !matches_.empty();
464 } 465 }
465 } 466 }
466 } 467 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider.h ('k') | chrome/browser/autocomplete/zero_suggest_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698