Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 43923002: Reland "Make Array.prototype.pop throw if the last element is not configurable." (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Reland "Make Array.prototype.pop throw if the last element is not configurable." This relands r17346. R=machenbach@chromium.org BUG=311164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-array-pop-nonconfigurable.js View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/presubmit.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
7 years, 1 month ago (2013-10-25 11:16:03 UTC) #1
Michael Achenbach
7 years, 1 month ago (2013-10-25 11:29:33 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698