Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/array.js

Issue 43923002: Reland "Make Array.prototype.pop throw if the last element is not configurable." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-array-pop-nonconfigurable.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index 2649798ac1c0b7edb94cecb0335e8e677e62c258..e98d7f5b53aba315558d9297950d093c7f308195 100644
--- a/src/array.js
+++ b/src/array.js
@@ -430,7 +430,7 @@ function ArrayPop() {
n--;
var value = this[n];
- delete this[n];
+ Delete(this, ToName(n), true);
this.length = n;
return value;
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-array-pop-nonconfigurable.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698