Resources restored from CSS cache should be able to trigger InsecureContent messages

Source/core/fetch/ResourceFetcher.cpp

Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index a1b36a8b9af81a6cf0e9e5104461b72d48feeae3..680d0e1de7b16323cb46948bc61222e83b75e40f 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -1191,8 +1191,15 @@ void ResourceFetcher::garbageCollectDocumentResources()
     m_documentResources.removeAll(resourcesToDelete);
 }
 
+void ResourceFetcher::maybeNotifyInsecureContent(const Resource* resource) const

[Mike West, 2014/08/19 13:34:13]

1. Why break this one-line call out into a separate function if it's only being
used in one place?

2. If we cache `http://example.com/script.js`, and then load it on
`https://example.com/`, the script should be blocked as active content. This
code would just write an error message to the console, and either add a shield
to the omnibox or break the HTTPS on the page. It wouldn't actually block the
resource load. Perhaps we should do so?

+{
+    // As a side effect browser will be notified.
+    checkInsecureContent(resource->type(), resource->lastResourceRequest().url(), resource->options().mixedContentBlockingTreatment);
+}
+
 void ResourceFetcher::notifyLoadedFromMemoryCache(Resource* resource)
 {
+    maybeNotifyInsecureContent(resource);
     if (!frame() || !frame()->page() || resource->status() != Resource::Cached || m_validatedURLs.contains(resource->url()))
         return;