Resources restored from CSS cache should be able to trigger InsecureContent messages

Source/core/fetch/ResourceFetcher.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 1173 matching lines @@
     StringVector resourcesToDelete;
 
     for (DocumentResourceMap::iterator it = m_documentResources.begin(); it != m_documentResources.end(); ++it) {
         if (it->value->hasOneHandle())
             resourcesToDelete.append(it->key);
     }
 
     m_documentResources.removeAll(resourcesToDelete);
 }
 
+void ResourceFetcher::maybeNotifyInsecureContent(const Resource* resource) const

[Mike West, 2014/08/19 13:34:13]

1. Why break this one-line call out into a separate function if it's only being
used in one place?

2. If we cache `http://example.com/script.js`, and then load it on
`https://example.com/`, the script should be blocked as active content. This
code would just write an error message to the console, and either add a shield
to the omnibox or break the HTTPS on the page. It wouldn't actually block the
resource load. Perhaps we should do so?

+{
+    // As a side effect browser will be notified.
+    checkInsecureContent(resource->type(), resource->lastResourceRequest().url(), resource->options().mixedContentBlockingTreatment);
+}
+
 void ResourceFetcher::notifyLoadedFromMemoryCache(Resource* resource)
 {
+    maybeNotifyInsecureContent(resource);
     if (!frame() || !frame()->page() || resource->status() != Resource::Cached || m_validatedURLs.contains(resource->url()))
         return;
 
     ResourceRequest request(resource->url());
     unsigned long identifier = createUniqueIdentifier();
     context().dispatchDidLoadResourceFromMemoryCache(request, resource->response());
     // FIXME: If willSendRequest changes the request, we don't respect it.
     willSendRequest(identifier, request, ResourceResponse(), resource->options().initiatorInfo);
     InspectorInstrumentation::markResourceAsCached(frame()->page(), identifier);
     context().sendRemainingDelegateMessages(m_documentLoader, identifier, resource->response(), resource->encodedSize());
@@ skipping 333 matching lines @@
 
 void ResourceFetcher::trace(Visitor* visitor)
 {
     visitor->trace(m_document);
     visitor->trace(m_loaders);
     visitor->trace(m_multipartLoaders);
     ResourceLoaderHost::trace(visitor);
 }
 
 }