Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 438993002: Add TaskMemory, which can read another Mach task’s memory, and its test (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add TaskMemory, which can read another Mach task’s memory, and its test. This also adds MachErrorMessage(), a test-only function that’s a dependency of TaskMemory’s test, and related test-only error message functions. TEST=util_test TaskMemory.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9f6d86742d6d

Patch Set 1 #

Patch Set 2 : Improvements #

Total comments: 4

Patch Set 3 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+876 lines, -0 lines) Patch
M crashpad.doxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
A util/mach/task_memory.h View 1 1 chunk +96 lines, -0 lines 0 comments Download
A util/mach/task_memory.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
A util/mach/task_memory_test.cc View 1 2 1 chunk +386 lines, -0 lines 0 comments Download
A util/test/errors.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A util/test/errors.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A util/test/mac/mach_errors.h View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A util/test/mac/mach_errors.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M util/util.gyp View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-01 22:09:22 UTC) #1
Robert Sesek
https://codereview.chromium.org/438993002/diff/40001/util/mach/task_memory_test.cc File util/mach/task_memory_test.cc (right): https://codereview.chromium.org/438993002/diff/40001/util/mach/task_memory_test.cc#newcode242 util/mach/task_memory_test.cc:242: TEST(TaskMemory, ReadCStringSizeLimited) { This test is rather large, and ...
6 years, 4 months ago (2014-08-03 14:56:43 UTC) #2
Mark Mentovai
Thanks! Feedback addressed.
6 years, 4 months ago (2014-08-03 17:14:09 UTC) #3
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-03 20:41:31 UTC) #4
Mark Mentovai
6 years, 4 months ago (2014-08-03 22:48:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 9f6d86742d6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698