Issue 438963004: Avoid a segfault in FeedbackServiceImpl::GetUserEmail().

Issue 438963004: Avoid a segfault in FeedbackServiceImpl::GetUserEmail(). (Closed)

Created:
6 years, 4 months ago by Daniel Erat

Modified:
6 years, 4 months ago

Reviewers:
rkc, Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Nikita (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Avoid a segfault in FeedbackServiceImpl::GetUserEmail(). Make the feedbackPrivate.getUserEmail not crash if chromeos::UserManager has been initialized but no user is logged in. BUG=399749 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287135

Patch Set 1 #

Patch Set 2 : sprinkle some consts around #

Total comments: 1

Patch Set 3 : s/GetLoggedInUser/GetActiveUser/ #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc	View	1 2	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

https://codereview.chromium.org/438963004/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc File chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc (right): https://codereview.chromium.org/438963004/diff/20001/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc#newcode45 chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc:45: const user_manager::User* user = manager ? manager->GetLoggedInUser() : NULL; ...

6 years, 4 months ago (2014-08-01 20:38:20 UTC) #3

Yoyo Zhou

LGTM, feel free to update the call; it looks as you have described.

6 years, 4 months ago (2014-08-01 20:39:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/438963004/40001

6 years, 4 months ago (2014-08-01 20:43:26 UTC) #6

Message was sent while issue was closed.

Change committed as 287135

Expand Messages | Collapse Messages