Avoid a segfault in FeedbackServiceImpl::GetUserEmail().

chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/feedback_private/feedback_service.h"
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/login/users/user_manager.h"
+#include "components/user_manager/user.h"
 
 namespace extensions {
 
 class FeedbackServiceImpl
     : public FeedbackService,
       public base::SupportsWeakPtr<FeedbackServiceImpl> {
  public:
   FeedbackServiceImpl();
   virtual ~FeedbackServiceImpl();
 
@@ skipping 11 matching lines @@
   return new FeedbackServiceImpl;
 }
 
 FeedbackServiceImpl::FeedbackServiceImpl() {
 }
 
 FeedbackServiceImpl::~FeedbackServiceImpl() {
 }
 
 std::string FeedbackServiceImpl::GetUserEmail() {
-  chromeos::UserManager* manager = chromeos::UserManager::Get();
-  if (!manager)
-    return std::string();
-  else
-    return manager->GetLoggedInUser()->display_email();
+  const chromeos::UserManager* manager = chromeos::UserManager::Get();
+  const user_manager::User* user = manager ? manager->GetLoggedInUser() : NULL;

[Daniel Erat, 2014/08/01 20:38:19]

should i also change this to call GetActiveUser() instead? i suspect so -- it
and GetLoggedInUser() return the same thing but the latter is deprecated.

+  return user ? user->display_email() : std::string();
 }
 
 void FeedbackServiceImpl::GetHistograms(std::string* histograms) {
   *histograms = base::StatisticsRecorder::ToJSON(std::string());
 }
 
 base::WeakPtr<FeedbackService> FeedbackServiceImpl::GetWeakPtr() {
   return AsWeakPtr();
 }
 
 }  // namespace extensions