Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 438623002: Add a UseCounter for the composite attribute on <img> (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for the composite attribute on <img> This was added for Apple's Dashboard in 2004: http://trac.webkit.org/changeset/6491 Hopefully it's not used on the Web and can be removed. Remove the FIXME as it certainly shouldn't be expanded. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/428363002/ so trybots would fail to apply patch.
6 years, 4 months ago (2014-07-31 14:44:58 UTC) #1
Mike West
LGTM, thanks for these. Looking forward to removing them entirely!
6 years, 4 months ago (2014-07-31 15:23:24 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-31 15:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/438623002/1
6 years, 4 months ago (2014-07-31 15:36:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-31 16:39:59 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 17:16:19 UTC) #6
Message was sent while issue was closed.
Change committed as 179326

Powered by Google App Engine
This is Rietveld 408576698