Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: content/renderer/render_frame_proxy.cc

Issue 438393004: Revert of Start using RenderFrameProxyHost objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_proxy.h" 5 #include "content/renderer/render_frame_proxy.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "content/common/frame_messages.h" 10 #include "content/common/frame_messages.h"
(...skipping 20 matching lines...) Expand all
31 } // namespace 31 } // namespace
32 32
33 // static 33 // static
34 RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame( 34 RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame(
35 RenderFrameImpl* frame_to_replace, 35 RenderFrameImpl* frame_to_replace,
36 int routing_id) { 36 int routing_id) {
37 CHECK_NE(routing_id, MSG_ROUTING_NONE); 37 CHECK_NE(routing_id, MSG_ROUTING_NONE);
38 38
39 scoped_ptr<RenderFrameProxy> proxy( 39 scoped_ptr<RenderFrameProxy> proxy(
40 new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID())); 40 new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID()));
41 41 #if 0
42 // TODO(nick): Enable this code when we're ready to create WebRemoteFrames.
42 blink::WebRemoteFrame* web_frame = NULL; 43 blink::WebRemoteFrame* web_frame = NULL;
43 if (frame_to_replace->GetWebFrame()->parent() && 44 if (frame_to_replace->GetWebFrame()->parent() &&
44 frame_to_replace->GetWebFrame()->parent()->isWebRemoteFrame()) { 45 frame_to_replace->GetWebFrame()->parent()->isWebRemoteFrame()) {
45 blink::WebRemoteFrame* parent_web_frame = 46 blink::WebRemoteFrame* parent_web_frame =
46 frame_to_replace->GetWebFrame()->parent()->toWebRemoteFrame(); 47 frame_to_replace->GetWebFrame()->parent()->toWebRemoteFrame();
47 web_frame = parent_web_frame->createRemoteChild("", proxy.get()); 48 web_frame = parent_web_frame->createRemoteChild("", proxy.get());
48 } else { 49 } else {
49 web_frame = blink::WebRemoteFrame::create(proxy.get()); 50 web_frame = blink::WebRemoteFrame::create(proxy.get());
50 } 51 }
51 52 #else
53 blink::WebFrame* web_frame = frame_to_replace->GetWebFrame();
54 #endif
52 proxy->Init(web_frame, frame_to_replace->render_view()); 55 proxy->Init(web_frame, frame_to_replace->render_view());
53 return proxy.release(); 56 return proxy.release();
54 } 57 }
55 58
56 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( 59 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy(
57 int routing_id, 60 int routing_id,
58 int parent_routing_id, 61 int parent_routing_id,
59 int render_view_routing_id) { 62 int render_view_routing_id) {
60 scoped_ptr<RenderFrameProxy> proxy( 63 scoped_ptr<RenderFrameProxy> proxy(
61 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE)); 64 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE));
62 RenderViewImpl* render_view = NULL; 65 RenderViewImpl* render_view = NULL;
63 blink::WebRemoteFrame* web_frame = NULL; 66 blink::WebRemoteFrame* web_frame = NULL;
64 if (parent_routing_id == MSG_ROUTING_NONE) { 67 if (parent_routing_id == MSG_ROUTING_NONE) {
65 // Create a top level frame. 68 // Create a top level frame.
66 render_view = RenderViewImpl::FromRoutingID(render_view_routing_id); 69 render_view = RenderViewImpl::FromRoutingID(render_view_routing_id);
67 web_frame = blink::WebRemoteFrame::create(proxy.get()); 70 web_frame = blink::WebRemoteFrame::create(proxy.get());
68 render_view->webview()->setMainFrame(web_frame); 71 render_view->webview()->setMainFrame(web_frame);
69 } else { 72 } else {
70 // Create a frame under an existing parent. The parent is always expected 73 // Create a frame under an existing parent. The parent is always expected to
71 // to be a RenderFrameProxy, because navigations initiated by local frames 74 // be a RenderFrameProxy, because navigations initiated by local frames
72 // should not wind up here. 75 // should not wind up here.
73 RenderFrameProxy* parent = 76 RenderFrameProxy* parent =
74 RenderFrameProxy::FromRoutingID(parent_routing_id); 77 RenderFrameProxy::FromRoutingID(parent_routing_id);
75 web_frame = parent->web_frame()->createRemoteChild("", proxy.get()); 78 CHECK(parent);
79 CHECK(parent->web_frame()->isWebRemoteFrame());
80 web_frame = parent->web_frame()->toWebRemoteFrame()->createRemoteChild(
81 "", proxy.get());
76 render_view = parent->render_view(); 82 render_view = parent->render_view();
77 } 83 }
78 84
79 proxy->Init(web_frame, render_view); 85 proxy->Init(web_frame, render_view);
80 86
81 return proxy.release(); 87 return proxy.release();
82 } 88 }
83 89
84 // static 90 // static
85 RenderFrameProxy* RenderFrameProxy::FromRoutingID(int32 routing_id) { 91 RenderFrameProxy* RenderFrameProxy::FromRoutingID(int32 routing_id) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 g_frame_map.Get().erase(it); 125 g_frame_map.Get().erase(it);
120 126
121 RenderThread::Get()->RemoveRoute(routing_id_); 127 RenderThread::Get()->RemoveRoute(routing_id_);
122 g_routing_id_proxy_map.Get().erase(routing_id_); 128 g_routing_id_proxy_map.Get().erase(routing_id_);
123 129
124 // TODO(nick): Call close unconditionally when web_frame() is always remote. 130 // TODO(nick): Call close unconditionally when web_frame() is always remote.
125 if (web_frame()->isWebRemoteFrame()) 131 if (web_frame()->isWebRemoteFrame())
126 web_frame()->close(); 132 web_frame()->close();
127 } 133 }
128 134
129 void RenderFrameProxy::Init(blink::WebRemoteFrame* web_frame, 135 void RenderFrameProxy::Init(blink::WebFrame* web_frame,
130 RenderViewImpl* render_view) { 136 RenderViewImpl* render_view) {
131 CHECK(web_frame); 137 CHECK(web_frame);
132 CHECK(render_view); 138 CHECK(render_view);
133 139
134 web_frame_ = web_frame; 140 web_frame_ = web_frame;
135 render_view_ = render_view; 141 render_view_ = render_view;
136 142
137 // TODO(nick): Should all RenderFrameProxies remain observers of their views? 143 // TODO(nick): Should all RenderFrameProxies remain observers of their views?
138 render_view_->RegisterRenderFrameProxy(this); 144 render_view_->RegisterRenderFrameProxy(this);
139 145
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 compositing_helper_->EnableCompositing(true); 226 compositing_helper_->EnableCompositing(true);
221 } 227 }
222 compositing_helper_->OnCompositorFrameSwapped(frame.Pass(), 228 compositing_helper_->OnCompositorFrameSwapped(frame.Pass(),
223 param.a.producing_route_id, 229 param.a.producing_route_id,
224 param.a.output_surface_id, 230 param.a.output_surface_id,
225 param.a.producing_host_id, 231 param.a.producing_host_id,
226 param.a.shared_memory_handle); 232 param.a.shared_memory_handle);
227 } 233 }
228 234
229 } // namespace 235 } // namespace
OLDNEW
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698