Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: Source/platform/audio/AudioDSPKernel.h

Issue 438293003: Enable Oilpan by default for webaudio/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/audio/AudioDSPKernel.h
diff --git a/Source/platform/audio/AudioDSPKernel.h b/Source/platform/audio/AudioDSPKernel.h
index a006864acd585a3962c8af5870099bfe3043c3d0..ff9d0945d8f7c23ed659f945e660a9ed13ce0324 100644
--- a/Source/platform/audio/AudioDSPKernel.h
+++ b/Source/platform/audio/AudioDSPKernel.h
@@ -67,6 +67,12 @@ public:
virtual double latencyTime() const = 0;
protected:
+ // Oilpan: This raw pointer is safe because the AudioDSPKernelProcessor object is guaranteed
tkent 2014/08/15 07:39:01 nit: I recommend to wrap code comments in 80 colum
haraken 2014/08/15 08:08:00 Done.
+ // to be kept alive while the AudioDSPKernel object is alive.
+ // Ideally we want to move the AudioDSPKernel hierarchy to the heap and use
+ // a Member<AudioDSPKernelProcessor>. However, we cannot do that because AudioDSPKernel can be
+ // allocated in audio threads (which are not registered to Oilpan).
+ GC_PLUGIN_IGNORE("")
AudioDSPKernelProcessor* m_kernelProcessor;
float m_sampleRate;
};

Powered by Google App Engine
This is Rietveld 408576698