Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 43803002: dumpAsText() is unnecessarily called in spellchecking tests (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
Reviewers:
tony, gmorrita
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

dumpAsText() is unnecessarily called in spellchecking tests dumpAsText is already called either by notifyDone (js-test-post.js) or by finishJSTest() when asynchronous spell checking is used. This is mostly WebKit changeset: http://trac.webkit.org/changeset/157949 In addition, remove dumpAsText and notifyDone from Blink's spellchecking tests where they should not have been added. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160618

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
grzegorz
7 years, 1 month ago (2013-10-25 10:30:20 UTC) #1
tony
LGTM
7 years, 1 month ago (2013-10-25 17:21:50 UTC) #2
grzegorz
On 2013/10/25 17:21:50, tony wrote: > LGTM Hi Tony, Could you commit it on behalf ...
7 years, 1 month ago (2013-10-25 18:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/43803002/1
7 years, 1 month ago (2013-10-25 18:30:11 UTC) #4
tony
On 2013/10/25 18:25:24, grzegorz wrote: > On 2013/10/25 17:21:50, tony wrote: > > LGTM > ...
7 years, 1 month ago (2013-10-25 18:30:17 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 20:17:02 UTC) #6
Message was sent while issue was closed.
Change committed as 160618

Powered by Google App Engine
This is Rietveld 408576698