LayoutTests/editing/spelling/spelling-huge-text.html - Issue 43803002: dumpAsText() is unnecessarily called in spellchecking tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/spelling/spelling-huge-text.html

Issue 43803002: dumpAsText() is unnecessarily called in spellchecking tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/spelling/spellcheck-editable-on-focus.html ('k') | LayoutTests/editing/spelling/spelling-huge-text-sync.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../fast/js/resources/js-test-pre.js"></script>	4 <script src="../../fast/js/resources/js-test-pre.js"></script>

5 </head>	5 </head>

6 <body onload="test();">	6 <body onload="test();">

7 <div id="console"></div>	7 <div id="console"></div>

8 <div id="editable" contenteditable></div>	8 <div id="editable" contenteditable></div>

9	9

10 <script>	10 <script>

(...skipping 23 matching lines...) Expand all Loading...
34 testEditable.innerText = testLongText;	34 testEditable.innerText = testLongText;

35	35

36 if (!window.internals) {	36 if (!window.internals) {

37 log("Test manually. See the description for steps");	37 log("Test manually. See the description for steps");

38 return;	38 return;

39 }	39 }

40	40

41 internals.settings.setUnifiedTextCheckerEnabled(true);	41 internals.settings.setUnifiedTextCheckerEnabled(true);

42 internals.settings.setAsynchronousSpellCheckingEnabled(true);	42 internals.settings.setAsynchronousSpellCheckingEnabled(true);

43	43

44 if (window.testRunner) {

45 testRunner.dumpAsText();

46 testRunner.waitUntilDone();

47 }

48

49 internals.setContinuousSpellCheckingEnabled(false);	44 internals.setContinuousSpellCheckingEnabled(false);

50 testEditable.focus();	45 testEditable.focus();

51 internals.setContinuousSpellCheckingEnabled(true);	46 internals.setContinuousSpellCheckingEnabled(true);

52 shouldBecomeEqual('internals.markerCountForNode(testEditable.childNodes[0], "spelling")', '6', function() {	47 shouldBecomeEqual('internals.markerCountForNode(testEditable.childNodes[0], "spelling")', '6', function() {

53 testEditable.removeChild(testEditable.childNodes[0]);	48 testEditable.removeChild(testEditable.childNodes[0]);

54 finishJSTest();	49 finishJSTest();

55 }, 5000 /* huge text needs more time to be spell checked */);	50 }, 5000 /* huge text needs more time to be spell checked */);

56 }	51 }

57 </script>	52 </script>

58 <script src="../../fast/js/resources/js-test-post.js"></script>	53 <script src="../../fast/js/resources/js-test-post.js"></script>

59 </body>	54 </body>

60 </html>	55 </html>

OLD	NEW