Issue 438010: Moving two tests to FLAKY tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438010: Moving two tests to FLAKY tests. (Closed)

Created:
11 years, 1 month ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, jcampan

Visibility:
Public.

Description

Moving two tests to FLAKY tests. TestHTTPSErrorWithNoNavEntry: fails differently on 32 and 64 bits due to timing issue. (We thought it's deterinistic, but this is apparently not) FindDisappearOnNavigate: due to asynchronous-ness on x11. BUG=28629, 28098 TEST=build and run browser_tests in 64bit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33068

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment fix #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
M	chrome/browser/ssl/ssl_browser_tests.cc	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/views/find_bar_host.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/find_bar_host_browsertest.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/438010/diff/1/4 File chrome/browser/views/find_bar_host_browsertest.cc (right): http://codereview.chromium.org/438010/diff/1/4#newcode477 chrome/browser/views/find_bar_host_browsertest.cc:477: IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FLAKY_FindDisappearOnNavigate) { > 80, and should this be ...

11 years, 1 month ago (2009-11-23 22:50:53 UTC) #2

LGTM

Expand Messages | Collapse Messages