Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: chrome/browser/views/find_bar_host.cc

Issue 438010: Moving two tests to FLAKY tests. (Closed)
Patch Set: comment fix Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/find_bar_host.h" 5 #include "chrome/browser/views/find_bar_host.h"
6 6
7 #include "app/gfx/path.h" 7 #include "app/gfx/path.h"
8 #include "app/slide_animation.h" 8 #include "app/slide_animation.h"
9 #include "base/keyboard_codes.h" 9 #include "base/keyboard_codes.h"
10 #include "base/scoped_handle.h" 10 #include "base/scoped_handle.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // FindBarTesting implementation: 110 // FindBarTesting implementation:
111 111
112 bool FindBarHost::GetFindBarWindowInfo(gfx::Point* position, 112 bool FindBarHost::GetFindBarWindowInfo(gfx::Point* position,
113 bool* fully_visible) { 113 bool* fully_visible) {
114 if (!find_bar_controller_ || 114 if (!find_bar_controller_ ||
115 #if defined(OS_WIN) 115 #if defined(OS_WIN)
116 !::IsWindow(host()->GetNativeView())) { 116 !::IsWindow(host()->GetNativeView())) {
117 #else 117 #else
118 false) { 118 false) {
119 // TODO(sky): figure out linux side. 119 // TODO(sky): figure out linux side.
120 // This is tricky due to asynchronous nature of x11.
121 // See bug http://crbug.com/28629.
120 #endif 122 #endif
121 if (position) 123 if (position)
122 *position = gfx::Point(); 124 *position = gfx::Point();
123 if (fully_visible) 125 if (fully_visible)
124 *fully_visible = false; 126 *fully_visible = false;
125 return false; 127 return false;
126 } 128 }
127 129
128 gfx::Rect window_rect; 130 gfx::Rect window_rect;
129 host()->GetBounds(&window_rect, true); 131 host()->GetBounds(&window_rect, true);
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // input. Otherwise Up and Down arrow key strokes get eaten. "Nom Nom Nom". 357 // input. Otherwise Up and Down arrow key strokes get eaten. "Nom Nom Nom".
356 render_view_host->ClearFocusedNode(); 358 render_view_host->ClearFocusedNode();
357 NativeWebKeyboardEvent event = GetKeyboardEvent(contents, key_stroke); 359 NativeWebKeyboardEvent event = GetKeyboardEvent(contents, key_stroke);
358 render_view_host->ForwardKeyboardEvent(event); 360 render_view_host->ForwardKeyboardEvent(event);
359 return true; 361 return true;
360 } 362 }
361 363
362 FindBarView* FindBarHost::find_bar_view() { 364 FindBarView* FindBarHost::find_bar_view() {
363 return static_cast<FindBarView*>(view()); 365 return static_cast<FindBarView*>(view());
364 } 366 }
OLDNEW
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/views/find_bar_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698