Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 437953003: Reuse the nonexistent handler frontend for transition handlers (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reuse the nonexistent handler frontend for transition handlers BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22808

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Make nonexistent non-architecture specific #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -224 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/mips64/stub-cache-mips64.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/stub-cache.h View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M src/stub-cache.cc View 1 2 3 4 chunks +36 lines, -35 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 1 2 2 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-04 09:30:15 UTC) #1
Igor Sheludko
https://codereview.chromium.org/437953003/diff/40001/src/stub-cache.cc File src/stub-cache.cc (right): https://codereview.chromium.org/437953003/diff/40001/src/stub-cache.cc#newcode981 src/stub-cache.cc:981: NonexistentFrontend(name, scratch1(), scratch2()); Now this thing will generate a ...
6 years, 4 months ago (2014-08-04 10:27:59 UTC) #2
Toon Verwaest
Addressed comments. PTAL
6 years, 4 months ago (2014-08-04 10:44:07 UTC) #3
Igor Sheludko
lgtm
6 years, 4 months ago (2014-08-04 10:45:31 UTC) #4
Toon Verwaest
6 years, 4 months ago (2014-08-04 10:47:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r22808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698