src/ic.cc - Issue 437953003: Reuse the nonexistent handler frontend for transition handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 437953003: Reuse the nonexistent handler frontend for transition handlers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 4fb55fc8abf15bf9291b46bed3cc85d71b352491..22367b7eaac25c870cbf8ed8fd1017b4d667fd25 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1434,7 +1434,8 @@ Handle<Code> StoreIC::CompileStoreHandler(LookupResult* lookup,

Handle<Map> transition(lookup->GetTransitionTarget());

PropertyDetails details = lookup->GetPropertyDetails();

- if (details.type() != CALLBACKS && details.attributes() == NONE) {

+ if (details.type() != CALLBACKS && details.attributes() == NONE &&

+ holder->HasFastProperties()) {

return compiler.CompileStoreTransition(transition, name);

}

} else {

« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »