Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 437843002: Invalid caret at the end of line in overtype mode (Closed)

Created:
6 years, 4 months ago by svillar
Modified:
6 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Invalid caret at the end of line in overtype mode When using overtype mode in content editable content we usually replace the caret by a block cursor that covers the next character to be replaced. However at the end of lines we should show the 'normal' blinking caret. In those cases we were incorrectly adding a selection block till the end of the container of the editable content. That's because we were using a complicated (and wrong) way to detect the end of lines based on modifying the internal selection used by the overtype mode. We now use the proper tools to detect the end of line detection which also supports bidi text. BUG=385003 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180002

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -7 lines) Patch
A LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-expected.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl-expected.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
svillar
Adding reviewers
6 years, 4 months ago (2014-08-01 14:51:36 UTC) #1
ojan
6 years, 4 months ago (2014-08-01 17:55:40 UTC) #2
ojan
6 years, 4 months ago (2014-08-01 17:56:36 UTC) #3
svillar
Ping reviewers. I understood this was kind of urgent.
6 years, 4 months ago (2014-08-07 10:51:13 UTC) #4
leviw_travelin_and_unemployed
https://codereview.chromium.org/437843002/diff/1/LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html File LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html (right): https://codereview.chromium.org/437843002/diff/1/LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html#newcode14 LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html:14: <body style = "font: 30px;" onload="run();""> Is the body ...
6 years, 4 months ago (2014-08-07 18:39:16 UTC) #5
svillar
Thanks for the review. I've just uploaded a new version of the CL. https://codereview.chromium.org/437843002/diff/1/LayoutTests/editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html File ...
6 years, 4 months ago (2014-08-08 09:01:25 UTC) #6
yosin_UTC9
LGTM
6 years, 4 months ago (2014-08-11 01:19:16 UTC) #7
svillar
The CQ bit was checked by svillar@igalia.com
6 years, 4 months ago (2014-08-11 07:10:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/437843002/20001
6 years, 4 months ago (2014-08-11 07:10:32 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-11 08:15:01 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 08:17:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12424)
6 years, 4 months ago (2014-08-11 08:17:55 UTC) #12
leviw_travelin_and_unemployed
owners LGTM.
6 years, 4 months ago (2014-08-11 22:40:16 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 22:46:40 UTC) #14
Message was sent while issue was closed.
Change committed as 180002

Powered by Google App Engine
This is Rietveld 408576698