Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: Source/core/editing/VisibleUnits.h

Issue 437843002: Invalid caret at the end of line in overtype mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 // lines 56 // lines
57 VisiblePosition startOfLine(const VisiblePosition &); 57 VisiblePosition startOfLine(const VisiblePosition &);
58 VisiblePosition endOfLine(const VisiblePosition &); 58 VisiblePosition endOfLine(const VisiblePosition &);
59 VisiblePosition previousLinePosition(const VisiblePosition&, int lineDirectionPo int, EditableType = ContentIsEditable); 59 VisiblePosition previousLinePosition(const VisiblePosition&, int lineDirectionPo int, EditableType = ContentIsEditable);
60 VisiblePosition nextLinePosition(const VisiblePosition&, int lineDirectionPoint, EditableType = ContentIsEditable); 60 VisiblePosition nextLinePosition(const VisiblePosition&, int lineDirectionPoint, EditableType = ContentIsEditable);
61 bool inSameLine(const VisiblePosition &, const VisiblePosition &); 61 bool inSameLine(const VisiblePosition &, const VisiblePosition &);
62 bool isStartOfLine(const VisiblePosition &); 62 bool isStartOfLine(const VisiblePosition &);
63 bool isEndOfLine(const VisiblePosition &); 63 bool isEndOfLine(const VisiblePosition &);
64 VisiblePosition logicalStartOfLine(const VisiblePosition &); 64 VisiblePosition logicalStartOfLine(const VisiblePosition &);
65 VisiblePosition logicalEndOfLine(const VisiblePosition &); 65 VisiblePosition logicalEndOfLine(const VisiblePosition &);
66 bool isLogicalEndOfLine(const VisiblePosition &);
66 VisiblePosition leftBoundaryOfLine(const VisiblePosition&, TextDirection); 67 VisiblePosition leftBoundaryOfLine(const VisiblePosition&, TextDirection);
67 VisiblePosition rightBoundaryOfLine(const VisiblePosition&, TextDirection); 68 VisiblePosition rightBoundaryOfLine(const VisiblePosition&, TextDirection);
68 69
69 // paragraphs (perhaps a misnomer, can be divided by line break elements) 70 // paragraphs (perhaps a misnomer, can be divided by line break elements)
70 VisiblePosition startOfParagraph(const VisiblePosition&, EditingBoundaryCrossing Rule = CannotCrossEditingBoundary); 71 VisiblePosition startOfParagraph(const VisiblePosition&, EditingBoundaryCrossing Rule = CannotCrossEditingBoundary);
71 VisiblePosition endOfParagraph(const VisiblePosition&, EditingBoundaryCrossingRu le = CannotCrossEditingBoundary); 72 VisiblePosition endOfParagraph(const VisiblePosition&, EditingBoundaryCrossingRu le = CannotCrossEditingBoundary);
72 VisiblePosition startOfNextParagraph(const VisiblePosition&); 73 VisiblePosition startOfNextParagraph(const VisiblePosition&);
73 VisiblePosition previousParagraphPosition(const VisiblePosition &, int x); 74 VisiblePosition previousParagraphPosition(const VisiblePosition &, int x);
74 VisiblePosition nextParagraphPosition(const VisiblePosition &, int x); 75 VisiblePosition nextParagraphPosition(const VisiblePosition &, int x);
75 bool isStartOfParagraph(const VisiblePosition &, EditingBoundaryCrossingRule = C annotCrossEditingBoundary); 76 bool isStartOfParagraph(const VisiblePosition &, EditingBoundaryCrossingRule = C annotCrossEditingBoundary);
(...skipping 19 matching lines...) Expand all
95 VisiblePosition startOfEditableContent(const VisiblePosition&); 96 VisiblePosition startOfEditableContent(const VisiblePosition&);
96 VisiblePosition endOfEditableContent(const VisiblePosition&); 97 VisiblePosition endOfEditableContent(const VisiblePosition&);
97 bool isEndOfEditableOrNonEditableContent(const VisiblePosition&); 98 bool isEndOfEditableOrNonEditableContent(const VisiblePosition&);
98 99
99 // Rect is local to the returned renderer 100 // Rect is local to the returned renderer
100 LayoutRect localCaretRectOfPosition(const PositionWithAffinity&, RenderObject*&) ; 101 LayoutRect localCaretRectOfPosition(const PositionWithAffinity&, RenderObject*&) ;
101 102
102 } // namespace blink 103 } // namespace blink
103 104
104 #endif // VisibleUnits_h 105 #endif // VisibleUnits_h
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698