Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 437733002: Fix inconsistency with null vs undefined in dart:js (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
sra1, Jacob
CC:
reviews_dartlang.org, justinfagnani
Visibility:
Public.

Description

Fix inconsistency with null vs undefined in dart:js BUG=https://code.google.com/p/dart/issues/detail?id=20305 R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38814

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + tests/lib/js/null_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + tests/lib/js/null_test.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-01 00:37:07 UTC) #1
sra1
lgtm
6 years, 4 months ago (2014-08-01 00:39:21 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r38814 (presubmit successful).
6 years, 4 months ago (2014-08-01 00:41:44 UTC) #3
Jacob
6 years, 4 months ago (2014-08-01 17:54:48 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698