Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: tests/lib/js/null_test.dart

Issue 437733002: Fix inconsistency with null vs undefined in dart:js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/js/dart2js/js_dart2js.dart ('k') | tests/lib/js/null_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/js/null_test.dart
diff --git a/pkg/web_components/test/location_wrapper_test.dart b/tests/lib/js/null_test.dart
similarity index 65%
copy from pkg/web_components/test/location_wrapper_test.dart
copy to tests/lib/js/null_test.dart
index a1c531ad50b6d1fa0737f10aa73ee0533142899d..82bc9df534a559bc24022b9f603641e7cb7a0209 100644
--- a/pkg/web_components/test/location_wrapper_test.dart
+++ b/tests/lib/js/null_test.dart
@@ -2,16 +2,16 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library template_wrappers_test;
+library null_test;
-import 'dart:html';
-import 'package:unittest/html_config.dart';
+import 'dart:js';
import 'package:unittest/unittest.dart';
+import 'package:unittest/html_config.dart';
main() {
useHtmlConfiguration();
-
- test('OK to access location with platform.js', () {
- expect(window.location.toString(), window.location.href);
+ test('null is sent as null', () {
+ expect(context['isNull'].apply([null]), isTrue);
+ expect(context['isUndefined'].apply([null]), isFalse);
});
}
« no previous file with comments | « sdk/lib/js/dart2js/js_dart2js.dart ('k') | tests/lib/js/null_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698