Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 437583002: TF: Lowering representation changes to machine operators (WIP: need inline allocation for some). Mo… (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer, bmeuer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

TF: Lowering representation changes to machine operators (WIP: need inline allocation for some). Move tests related to lowering representation changes into test-changes-lowering.cc. R=bmeurer@chromium.org, bmeuer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22781

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -370 lines) Patch
M src/compiler/simplified-lowering.h View 1 chunk +18 lines, -12 lines 1 comment Download
M src/compiler/simplified-lowering.cc View 5 chunks +166 lines, -40 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +5 lines, -5 lines 0 comments Download
A test/cctest/compiler/test-changes-lowering.cc View 1 chunk +386 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 4 chunks +12 lines, -313 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 4 months ago (2014-07-31 16:29:16 UTC) #1
Benedikt Meurer
LGTM with comment. https://codereview.chromium.org/437583002/diff/1/src/compiler/simplified-lowering.h File src/compiler/simplified-lowering.h (right): https://codereview.chromium.org/437583002/diff/1/src/compiler/simplified-lowering.h#newcode19 src/compiler/simplified-lowering.h:19: class SimplifiedLowering : public LoweringBuilder { ...
6 years, 4 months ago (2014-08-01 04:35:44 UTC) #2
titzer
On 2014/08/01 04:35:44, Benedikt Meurer wrote: > LGTM with comment. > > https://codereview.chromium.org/437583002/diff/1/src/compiler/simplified-lowering.h > File ...
6 years, 4 months ago (2014-08-01 07:53:27 UTC) #3
titzer
6 years, 4 months ago (2014-08-01 08:16:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22781 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698