Issue 437563004: Revert 287212 "Create a policy for controlling whether or not de..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437563004: Revert 287212 "Create a policy for controlling whether or not de..." (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
Mike Lerman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 287212 "Create a policy for controlling whether or not de..." Likely broke the tree, UserManagerUIBrowserTest.PageLoads http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/43558/steps/browser_tests/logs/PageLoads > Create a policy for controlling whether or not desktop browser can access guest mode. > > BUG=306322 > TEST=When the policy prohibits guest mode, the option should not be selectable from the User Manager. When no policy or policy permits guest mode, Guest Mode should be selectable. > > Review URL: https://codereview.chromium.org/385073008 TBR=mlerman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287220

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -66 lines)			Patch
M	trunk/src/chrome/browser/browser_process_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/policy/configuration_policy_handler_list_factory.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/user_manager/user_manager.js	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc	View	6 chunks	+5 lines, -20 lines	0 comments	Download
M	trunk/src/chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/pref_names.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/test/data/policy/policy_test_cases.json	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/components/policy/resources/policy_templates.json	View	2 chunks	+1 line, -17 lines	0 comments	Download
M	trunk/src/tools/metrics/histograms/histograms.xml	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

pneubeck (no reviews)

6 years, 4 months ago (2014-08-02 18:22:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r287220 (tree was closed).