Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385073008: Browser-based guest policy implementation (Closed)

Created:
6 years, 5 months ago by Mike Lerman
Modified:
6 years, 4 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create a policy for controlling whether or not desktop browser can access guest mode. BUG=306322 TEST=When the policy prohibits guest mode, the option should not be selectable from the User Manager. When no policy or policy permits guest mode, Guest Mode should be selectable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289536

Patch Set 1 #

Total comments: 16

Patch Set 2 : Joao's nits and policy suggestions #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Joao more nits #

Patch Set 5 : Rebase, mostly, and trying to get hiding divs to work #

Patch Set 6 : User Manager UI hides guest mode #

Total comments: 4

Patch Set 7 : Nikita's nit #

Patch Set 8 : Rebase #

Patch Set 9 : Value for policy pref tests #

Patch Set 10 : Rebase #

Patch Set 11 : Move policy test #

Patch Set 12 : Gimme a rebase here #

Patch Set 13 : And a rebase there #

Patch Set 14 : Here a rebase #

Patch Set 15 : Remove UI element which cause Blink to crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +10 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +16 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (0 generated)
Mike Lerman
Hi Joao, I have some more work to do around the UI, but I think ...
6 years, 5 months ago (2014-07-11 20:27:23 UTC) #1
Joao da Silva
Looks mostly good, some suggestions inline. https://codereview.chromium.org/385073008/diff/1/chrome/browser/resources/user_manager/control_bar.js File chrome/browser/resources/user_manager/control_bar.js (right): https://codereview.chromium.org/385073008/diff/1/chrome/browser/resources/user_manager/control_bar.js#newcode138 chrome/browser/resources/user_manager/control_bar.js:138: //$('guest-user-button').hidden = !this.showGuest_; ...
6 years, 5 months ago (2014-07-14 17:12:00 UTC) #2
Mike Lerman
https://codereview.chromium.org/385073008/diff/1/chrome/browser/resources/user_manager/control_bar.js File chrome/browser/resources/user_manager/control_bar.js (right): https://codereview.chromium.org/385073008/diff/1/chrome/browser/resources/user_manager/control_bar.js#newcode138 chrome/browser/resources/user_manager/control_bar.js:138: //$('guest-user-button').hidden = !this.showGuest_; On 2014/07/14 17:11:59, Joao da Silva ...
6 years, 5 months ago (2014-07-15 14:28:12 UTC) #3
Joao da Silva
lgtm after fixing the pending nits https://codereview.chromium.org/385073008/diff/40001/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right): https://codereview.chromium.org/385073008/diff/40001/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc#newcode386 chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:386: // The third ...
6 years, 5 months ago (2014-07-15 14:39:09 UTC) #4
Mike Lerman
Hi Alexei, Can you review the histograms change pertaining to the new policy? Thanks, Mike
6 years, 5 months ago (2014-07-15 14:40:57 UTC) #5
Alexei Svitkine (slow)
histograms lgtm
6 years, 5 months ago (2014-07-15 14:44:16 UTC) #6
Mike Lerman
Hi Reviewers, PTAL. Nikita - c/b/resources Monica - c/b/ui/webui/signin Scott - c/b/browser_process_impl.cc Thanks! Please note ...
6 years, 5 months ago (2014-07-17 15:21:52 UTC) #7
sky
c/b/browser_process_impl.cc LGTM
6 years, 5 months ago (2014-07-17 16:16:13 UTC) #8
Nikita (slow)
c/b/resources lgtm with nits https://codereview.chromium.org/385073008/diff/120001/chrome/browser/resources/user_manager/user_manager.js File chrome/browser/resources/user_manager/user_manager.js (right): https://codereview.chromium.org/385073008/diff/120001/chrome/browser/resources/user_manager/user_manager.js#newcode135 chrome/browser/resources/user_manager/user_manager.js:135: // Hide the header bar ...
6 years, 5 months ago (2014-07-18 05:37:48 UTC) #9
noms (inactive)
webui/signin lgtm
6 years, 5 months ago (2014-07-18 14:07:14 UTC) #10
Mike Lerman
Thanks everyone! Now I wait on the blocking Blink bug before I land this. https://codereview.chromium.org/385073008/diff/120001/chrome/browser/resources/user_manager/user_manager.js ...
6 years, 5 months ago (2014-07-18 14:20:59 UTC) #11
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 5 months ago (2014-07-25 15:50:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/160001
6 years, 5 months ago (2014-07-25 15:51:19 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 17:34:46 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 18:17:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2411)
6 years, 5 months ago (2014-07-25 18:17:24 UTC) #16
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-07-29 15:11:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/180001
6 years, 4 months ago (2014-07-29 15:12:38 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 18:44:51 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 18:55:34 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/977)
6 years, 4 months ago (2014-07-29 18:55:34 UTC) #21
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-07-31 20:43:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/220001
6 years, 4 months ago (2014-07-31 20:45:20 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-31 21:58:36 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 22:02:21 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/46863) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36163) android_chromium_gn_compile_rel ...
6 years, 4 months ago (2014-07-31 22:02:21 UTC) #26
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-01 15:54:27 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/240001
6 years, 4 months ago (2014-08-01 15:56:03 UTC) #28
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-01 18:55:19 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/260001
6 years, 4 months ago (2014-08-01 18:56:38 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-02 10:30:08 UTC) #31
commit-bot: I haz the power
Change committed as 287212
6 years, 4 months ago (2014-08-02 13:20:27 UTC) #32
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-13 19:42:36 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/385073008/300001
6 years, 4 months ago (2014-08-13 19:43:36 UTC) #34
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 10:55:48 UTC) #35
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 12:36:50 UTC) #36
Message was sent while issue was closed. 
Committed patchset #15 (300001) as 289536

Powered by Google App Engine
This is Rietveld 408576698