Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/sqlite/sqlite.gyp

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/sqlite/sqlite.gyp
diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp
index 8e897ad1184137f7aa7fc6b74c5032e6bc90be92..c1ec3bc3bd0850ad579808d2125f13893a89f7cd 100644
--- a/third_party/sqlite/sqlite.gyp
+++ b/third_party/sqlite/sqlite.gyp
@@ -119,6 +119,14 @@
'msvs_disabled_warnings': [
4018, 4244, 4267,
],
+ 'variables': {
+ 'clang_warning_flags': [
+ # sqlite does `if (*a++ && *b++);` in a non-buggy way.
+ '-Wno-empty-body',
+ # sqlite has some `unsigned < 0` checks.
+ '-Wno-tautological-compare',
+ ],
+ },
'conditions': [
['OS=="linux"', {
'link_settings': {
@@ -153,20 +161,6 @@
'-Wno-pointer-to-int-cast',
],
}],
- ['clang==1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- # sqlite does `if (*a++ && *b++);` in a non-buggy way.
- '-Wno-empty-body',
- # sqlite has some `unsigned < 0` checks.
- '-Wno-tautological-compare',
- ],
- },
- 'cflags': [
- '-Wno-empty-body',
- '-Wno-tautological-compare',
- ],
- }],
],
}],
],

Powered by Google App Engine
This is Rietveld 408576698