Refactor how clang warning flags are set.

third_party/sqlite/sqlite.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'use_system_sqlite%': 0,
     'required_sqlite_version': '3.6.1',
   },
   'target_defaults': {
@@ skipping 101 matching lines @@
           ],
           'direct_dependent_settings': {
             'include_dirs': [
               '.',
               '../..',
             ],
           },
           'msvs_disabled_warnings': [
             4018, 4244, 4267,
           ],
+          'variables': {
+            'clang_warning_flags': [
+              # sqlite does `if (*a++ && *b++);` in a non-buggy way.
+              '-Wno-empty-body',
+              # sqlite has some `unsigned < 0` checks.
+              '-Wno-tautological-compare',
+            ],
+          },
           'conditions': [
             ['OS=="linux"', {
               'link_settings': {
                 'libraries': [
                   '-ldl',
                 ],
               },
             }],
             ['OS == "mac" or OS == "ios"', {
               'link_settings': {
@@ skipping 14 matching lines @@
             }],
             ['os_posix == 1 and OS != "mac" and OS != "android"', {
               'cflags': [
                 # SQLite doesn't believe in compiler warnings,
                 # preferring testing.
                 #   http://www.sqlite.org/faq.html#q17
                 '-Wno-int-to-pointer-cast',
                 '-Wno-pointer-to-int-cast',
               ],
             }],
-            ['clang==1', {
-              'xcode_settings': {
-                'WARNING_CFLAGS': [
-                  # sqlite does `if (*a++ && *b++);` in a non-buggy way.
-                  '-Wno-empty-body',
-                  # sqlite has some `unsigned < 0` checks.
-                  '-Wno-tautological-compare',
-                ],
-              },
-              'cflags': [
-                '-Wno-empty-body',
-                '-Wno-tautological-compare',
-              ],
-            }],
           ],
         }],
       ],
     },
   ],
   'conditions': [
     ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android" and not use_system_sqlite', {
       'targets': [
         {
           'target_name': 'sqlite_shell',
@@ skipping 21 matching lines @@
             '../icu/icu.gyp:icuuc',
           ],
           'sources': [
             'src/ext/icu/icu.c',
           ],
         },
       ],
     }],
   ],
 }