Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/skia_library.gypi

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« skia/skia_common.gypi ('K') | « skia/skia_common.gypi ('k') | third_party/libxml/libxml.gyp » ('j') | third_party/snappy/snappy.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia_library.gypi
diff --git a/skia/skia_library.gypi b/skia/skia_library.gypi
index 7410d7cb94b27aaf6026ba354b5bb85808a1a8e0..d1fd91eaa6c93dc7a9c8c4356dcf89d1d9f7eda6 100644
--- a/skia/skia_library.gypi
+++ b/skia/skia_library.gypi
@@ -358,18 +358,6 @@
'../third_party/skia/src/utils/win/SkHRESULT.cpp',
],
}],
- # TODO(scottmg): http://crbug.com/177306
- ['clang==1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS!': [
- # Don't warn about string->bool used in asserts.
- '-Wstring-conversion',
- ],
- },
- 'cflags!': [
- '-Wstring-conversion',
- ],
- }],
],
'target_conditions': [
# Pull in specific Mac files for iOS (which have been filtered out
« skia/skia_common.gypi ('K') | « skia/skia_common.gypi ('k') | third_party/libxml/libxml.gyp » ('j') | third_party/snappy/snappy.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698