Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: skia/skia_common.gypi

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/set_clang_warning_flags.gypi ('K') | « skia/skia_chrome.gypi ('k') | skia/skia_library.gypi » ('j') | third_party/snappy/snappy.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia_common.gypi
diff --git a/skia/skia_common.gypi b/skia/skia_common.gypi
index d56070eecd4106c5102e28b13bf3b9e415c97426..2d89b4c90df4b46a683da46bfe4afc5cab8b9822 100644
--- a/skia/skia_common.gypi
+++ b/skia/skia_common.gypi
@@ -137,6 +137,11 @@
'skia_support_pdf': 1,
}],
],
+ # TODO(scottmg): http://crbug.com/177306
+ 'clang_warning_flags': [
+ # Don't warn about string->bool used in asserts.
+ '-Wstring-conversion',
hans 2014/08/14 21:11:02 I just noticed this: it looks like this is adding
Nico 2014/08/14 21:15:35 That looks wrong, it should've probably been clang
scottmg 2014/08/14 21:18:10 Looks like they're mostly gone https://code.google
+ ]
},
'skia_support_gpu': '<(skia_support_gpu)',
'skia_support_pdf': '<(skia_support_pdf)',
« build/set_clang_warning_flags.gypi ('K') | « skia/skia_chrome.gypi ('k') | skia/skia_library.gypi » ('j') | third_party/snappy/snappy.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698