Issue 437543002: Revert of Add {Will,Did}StartBrowser to record_wpr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437543002: Revert of Add {Will,Did}StartBrowser to record_wpr (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
ariblue, dtu, tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Add {Will,Did}StartBrowser to record_wpr (https://codereview.chromium.org/427093002/) Reason for revert: Broke telemetry unittests. http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12601/steps/telemetry_unittests/logs/stdio Original issue's description: > Add {Will,Did}StartBrowser to record_wpr. > > Needed for PageMeasurements that assume a self._power_metric is created during the WillStartBrowser step. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286744 TBR=dtu@chromium.org,tonyg@chromium.org,ariblue@google.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286794

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -35 lines)			Patch
	M	tools/telemetry/telemetry/page/record_wpr.py	View		2 chunks	+0 lines, -12 lines	0 comments	Download
	M	tools/telemetry/telemetry/page/record_wpr_unittest.py	View		8 chunks	+11 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

pneubeck (no reviews)

Created Revert of Add {Will,Did}StartBrowser to record_wpr

6 years, 4 months ago (2014-07-31 13:39:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/437543002/1

6 years, 4 months ago (2014-07-31 13:40:47 UTC) #2

Message was sent while issue was closed.

Change committed as 286794