Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 424213007: Revert of Remove prefixed Pointer Lock API. (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
Reviewers:
scheib, abarth-chromium
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Revert of Remove prefixed Pointer Lock API. (https://codereview.chromium.org/424093006/) Reason for revert: The change broke several Chromium OS interactive_ui_tests: ExtensionPointerLockAccessFail ExtensionPointerLockAccessPass EscapingMouseLock MouseLockSilentAfterTargetUnlock TestTabDoesntExitMouseLockOnSubFrameNavigation TestTabExitsMouseLockOnGoBack TestTabExitsMouseLockOnNavigation PointerLock_PointerLockLostWithFocus that were using the prefixed API (""Uncaught TypeError: undefined is not a function"). See http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/735/steps/interactive_ui_tests/logs/stdio Original issue's description: > Remove prefixed Pointer Lock API. > > The Pointer Lock API http://www.w3.org/TR/pointerlock has already been > implemented without prefix, this change removes the 'webkit' prefixed > API endpoints. > > Intent to Deprecate and Remove: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tN8fWRtG0MI > > BUG=398457 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179172 TBR=abarth@chromium.org,scheib@chromium.org NOTREECHECKS=true NOTRY=true BUG=398457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1304 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed.html View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed.html View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/iframe-allows-inner-iframe-prefixed.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/iframe-common-prefixed.js View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/inner-iframe-prefixed.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness-prefixed.js View 1 chunk +88 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/lock-already-locked-prefixed.html View 1 chunk +63 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/lock-already-locked-prefixed-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed.html View 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/mouse-event-api-prefixed.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/mouse-event-api-prefixed-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/mouse-event-delivery-prefixed.html View 1 chunk +102 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/mouse-event-delivery-prefixed-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointer-lock-api-prefixed.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointer-lock-api-prefixed-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed.html View 1 chunk +117 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed-expected.txt View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed.html View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/PointerLockController.cpp View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Created Revert of Remove prefixed Pointer Lock API.
6 years, 4 months ago (2014-07-30 00:47:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/424213007/1
6 years, 4 months ago (2014-07-30 00:49:02 UTC) #2
commit-bot: I haz the power
Change committed as 179186
6 years, 4 months ago (2014-07-30 00:50:39 UTC) #3
scheib
6 years, 4 months ago (2014-08-01 20:23:19 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/437443005/ by scheib@chromium.org.

The reason for reverting is: Downstream tests have been updated to use
unprefixed pointer lock..

Powered by Google App Engine
This is Rietveld 408576698