Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: pkg/analysis_server/test/integration/analysis_error_int_test.dart

Issue 437383003: Simplify handling of pathnames in integration tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis_error_int_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis_error_int_test.dart b/pkg/analysis_server/test/integration/analysis_error_int_test.dart
index 662957ac82414f27acdfb28e59425f7cb6260f3c..4ba22f587c8001f296cf17a78e9524beda9b9551 100644
--- a/pkg/analysis_server/test/integration/analysis_error_int_test.dart
+++ b/pkg/analysis_server/test/integration/analysis_error_int_test.dart
@@ -14,14 +14,15 @@ import 'protocol_matchers.dart';
class AnalysisErrorIntegrationTest extends AbstractAnalysisServerIntegrationTest
{
test_detect_simple_error() {
- writeFile('test.dart',
+ String pathname = sourcePath('test.dart');
+ writeFile(pathname,
'''
main() {
var x // parse error: missing ';'
}''');
- setAnalysisRoots(['']);
+ standardAnalysisRoot();
return analysisFinished.then((_) {
- String filePath = normalizePath('test.dart');
+ String filePath = pathname;
Brian Wilkerson 2014/08/04 23:26:51 I'm not sure what the value of defining a local va
Paul Berry 2014/08/05 03:48:45 Oops, not sure what I was thinking there. Fixed.
expect(currentAnalysisErrors[filePath], isList);
List errors = currentAnalysisErrors[filePath];
expect(errors, hasLength(1));

Powered by Google App Engine
This is Rietveld 408576698