Simplify handling of pathnames in integration tests.

pkg/analysis_server/test/integration/analysis_error_int_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis.error;
 
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'integration_tests.dart';
 import 'protocol_matchers.dart';
 
 @ReflectiveTestCase()
 class AnalysisErrorIntegrationTest extends AbstractAnalysisServerIntegrationTest
     {
   test_detect_simple_error() {
-    writeFile('test.dart',
+    String pathname = sourcePath('test.dart');
+    writeFile(pathname,
         '''
 main() {
   var x // parse error: missing ';'
 }''');
-    setAnalysisRoots(['']);
+    standardAnalysisRoot();
     return analysisFinished.then((_) {
-      String filePath = normalizePath('test.dart');
+      String filePath = pathname;

[Brian Wilkerson, 2014/08/04 23:26:51]

I'm not sure what the value of defining a local variable is, but given that it
was already there I won't comment on it.

[Paul Berry, 2014/08/05 03:48:45]

Oops, not sure what I was thinking there.  Fixed.

       expect(currentAnalysisErrors[filePath], isList);
       List errors = currentAnalysisErrors[filePath];
       expect(errors, hasLength(1));
       expect(errors[0], isAnalysisError);
       expect(errors[0]['location']['file'], equals(filePath));
     });
   }
 }
 
 main() {
   runReflectiveTests(AnalysisErrorIntegrationTest);
 }