Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 437183002: Make start node a value input to parameter nodes. (Closed)

Created:
6 years, 4 months ago by sigurds
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
Project:
v8
Visibility:
Public.

Description

Make start node a value input to parameter nodes. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22851

Patch Set 1 #

Patch Set 2 : Add start node as input to parameter nodes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -91 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 5 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/structured-machine-assembler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/graph-tester.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/simplified-graph-builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-phi-reducer.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 25 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
6 years, 4 months ago (2014-08-04 08:37:38 UTC) #1
Michael Starzinger
LGTM.
6 years, 4 months ago (2014-08-05 08:26:01 UTC) #2
sigurds
6 years, 4 months ago (2014-08-05 08:47:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698