Make start node a value input to parameter nodes.

test/cctest/compiler/test-js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler/graph-inl.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/typer.h"
 
 using namespace v8::internal;
 using namespace v8::internal::compiler;
 
 class JSTypedLoweringTester : public HandleAndZoneScope {
  public:
-  JSTypedLoweringTester()
+  explicit JSTypedLoweringTester(int num_parameters = 0)
       : isolate(main_isolate()),
         binop(NULL),
         unop(NULL),
         javascript(main_zone()),
         machine(main_zone()),
         simplified(main_zone()),
         common(main_zone()),
         graph(main_zone()),
         typer(main_zone()),
         source_positions(&graph),
         context_node(NULL) {
     typer.DecorateGraph(&graph);
+    Node* s = graph.NewNode(common.Start(num_parameters));
+    graph.SetStart(s);
   }
 
   Isolate* isolate;
   Operator* binop;
   Operator* unop;
   JSOperatorBuilder javascript;
   MachineOperatorBuilder machine;
   SimplifiedOperatorBuilder simplified;
   CommonOperatorBuilder common;
   Graph graph;
   Typer typer;
   SourcePositionTable source_positions;
   Node* context_node;
 
   Node* Parameter(Type* t, int32_t index = 0) {
-    Node* n = graph.NewNode(common.Parameter(index));
+    Node* n = graph.NewNode(common.Parameter(index), graph.start());
     NodeProperties::SetBounds(n, Bounds(Type::None(), t));
     return n;
   }
 
   Node* reduce(Node* node) {
     JSGraph jsgraph(&graph, &common, &typer);
     JSTypedLowering reducer(&jsgraph, &source_positions);
     Reduction reduction = reducer.Reduce(node);
     if (reduction.Changed()) return reduction.replacement();
     return node;
   }
 
-  Node* start() {
-    Node* s = graph.start();
-    if (s == NULL) {
-      s = graph.NewNode(common.Start());
-      graph.SetStart(s);
-    }
-    return s;
-  }
+  Node* start() { return graph.start(); }
 
   Node* context() {
     if (context_node == NULL) {
-      context_node = graph.NewNode(common.Parameter(-1));
+      context_node = graph.NewNode(common.Parameter(-1), graph.start());
     }
     return context_node;
   }
 
   Node* control() { return start(); }
 
   void CheckPureBinop(IrOpcode::Value expected, Node* node) {
     CHECK_EQ(expected, node->opcode());
     CHECK_EQ(2, node->InputCount());  // should not have context, effect, etc.
   }
@@ skipping 1256 matching lines @@
           CHECK_EQ(p1, r->InputAt(0));
           CHECK_EQ(p0, r->InputAt(1));
         } else {
           CHECK_EQ(p0, r->InputAt(0));
           CHECK_EQ(p1, r->InputAt(1));
         }
       }
     }
   }
 }