Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 437163007: Revert of Implement scroll handler latency tracking (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Implement scroll handler latency tracking (https://codereview.chromium.org/365463003/) Reason for revert: Breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no begin component" http://chromegw/i/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf/builds/16918/steps/smoothness.top_25/logs/stdio TBR=rschoen@chromium.org Original issue's description: > Implement scroll handler latency tracking > > Since scroll handlers do not block composited scrolling, the existing > input latency metric will only report the response time for the > compositor when scrolling a page with a handler. This is not accurate > for pages that implement scroll-synchronized effects, because the > scroll handler needs to be invoked so that the page contents are > updated with the new scroll offset. > > This patch fixes the problem by forwarding latency information from the > impl to the main thread when we are scrolling a layer that has an active > scroll event handler. > > In the case the scroll handler is no-op, the latency information will be > terminated as a failed commit. > > Sample trace: > https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing > > BUG=347366 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282117 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -220 lines) Patch
M cc/base/latency_info_swap_promise.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/base/latency_info_swap_promise.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/base/latency_info_swap_promise_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/latency_info_swap_promise_monitor.cc View 2 chunks +8 lines, -62 lines 0 comments Download
M cc/base/swap_promise.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/base/swap_promise_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +11 lines, -20 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +5 lines, -73 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/events/latency_info.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/latency_info.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
tonyg
Created Revert of Implement scroll handler latency tracking
6 years, 4 months ago (2014-08-04 19:26:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/437163007/1
6 years, 4 months ago (2014-08-04 19:28:40 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 19:28:40 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-04 19:28:42 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-04 19:56:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/437163007/1
6 years, 4 months ago (2014-08-04 19:59:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-04 23:10:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 23:18:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/3107)
6 years, 4 months ago (2014-08-04 23:18:57 UTC) #9
sadrul
6 years, 4 months ago (2014-08-05 05:00:52 UTC) #10
On 2014/08/04 23:18:57, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_chromium_rel on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

Revert drover-landed in crrev.com/287458

Powered by Google App Engine
This is Rietveld 408576698