Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: cc/trees/layer_tree_host_impl.cc

Issue 437163007: Revert of Implement scroll handler latency tracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_impl.h" 5 #include "cc/trees/layer_tree_host_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 return layer_impl != NULL; 498 return layer_impl != NULL;
499 } 499 }
500 500
501 scoped_ptr<SwapPromiseMonitor> 501 scoped_ptr<SwapPromiseMonitor>
502 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor( 502 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor(
503 ui::LatencyInfo* latency) { 503 ui::LatencyInfo* latency) {
504 return scoped_ptr<SwapPromiseMonitor>( 504 return scoped_ptr<SwapPromiseMonitor>(
505 new LatencyInfoSwapPromiseMonitor(latency, NULL, this)); 505 new LatencyInfoSwapPromiseMonitor(latency, NULL, this));
506 } 506 }
507 507
508 void LayerTreeHostImpl::QueueSwapPromiseForMainThreadScrollUpdate(
509 scoped_ptr<SwapPromise> swap_promise) {
510 swap_promises_for_main_thread_scroll_update_.push_back(swap_promise.Pass());
511 }
512
513 void LayerTreeHostImpl::TrackDamageForAllSurfaces( 508 void LayerTreeHostImpl::TrackDamageForAllSurfaces(
514 LayerImpl* root_draw_layer, 509 LayerImpl* root_draw_layer,
515 const LayerImplList& render_surface_layer_list) { 510 const LayerImplList& render_surface_layer_list) {
516 // For now, we use damage tracking to compute a global scissor. To do this, we 511 // For now, we use damage tracking to compute a global scissor. To do this, we
517 // must compute all damage tracking before drawing anything, so that we know 512 // must compute all damage tracking before drawing anything, so that we know
518 // the root damage rect. The root damage rect is then used to scissor each 513 // the root damage rect. The root damage rect is then used to scissor each
519 // surface. 514 // surface.
520 515
521 for (int surface_index = render_surface_layer_list.size() - 1; 516 for (int surface_index = render_surface_layer_list.size() - 1;
522 surface_index >= 0; 517 surface_index >= 0;
(...skipping 2125 matching lines...) Expand 10 before | Expand all | Expand 10 after
2648 // which the layer moved. 2643 // which the layer moved.
2649 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x()); 2644 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x());
2650 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis); 2645 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis);
2651 2646
2652 if (gfx::ToRoundedVector2d(pending_delta).IsZero()) 2647 if (gfx::ToRoundedVector2d(pending_delta).IsZero())
2653 break; 2648 break;
2654 } 2649 }
2655 2650
2656 bool did_scroll_content = did_scroll_x || did_scroll_y; 2651 bool did_scroll_content = did_scroll_x || did_scroll_y;
2657 if (did_scroll_content) { 2652 if (did_scroll_content) {
2658 // If we are scrolling with an active scroll handler, forward latency
2659 // tracking information to the main thread so the delay introduced by the
2660 // handler is accounted for.
2661 if (scroll_affects_scroll_handler())
2662 NotifySwapPromiseMonitorsOfForwardingToMainThread();
2663 client_->SetNeedsCommitOnImplThread(); 2653 client_->SetNeedsCommitOnImplThread();
2664 SetNeedsRedraw(); 2654 SetNeedsRedraw();
2665 client_->RenewTreePriority(); 2655 client_->RenewTreePriority();
2666 } 2656 }
2667 2657
2668 // Scrolling along an axis resets accumulated root overscroll for that axis. 2658 // Scrolling along an axis resets accumulated root overscroll for that axis.
2669 if (did_scroll_x) 2659 if (did_scroll_x)
2670 accumulated_root_overscroll_.set_x(0); 2660 accumulated_root_overscroll_.set_x(0);
2671 if (did_scroll_y) 2661 if (did_scroll_y)
2672 accumulated_root_overscroll_.set_y(0); 2662 accumulated_root_overscroll_.set_y(0);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2954 for (size_t i = 0; i < layer_impl->children().size(); ++i) 2944 for (size_t i = 0; i < layer_impl->children().size(); ++i)
2955 CollectScrollDeltas(scroll_info, layer_impl->children()[i]); 2945 CollectScrollDeltas(scroll_info, layer_impl->children()[i]);
2956 } 2946 }
2957 2947
2958 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() { 2948 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
2959 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet()); 2949 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet());
2960 2950
2961 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer()); 2951 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer());
2962 scroll_info->page_scale_delta = active_tree_->page_scale_delta(); 2952 scroll_info->page_scale_delta = active_tree_->page_scale_delta();
2963 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta); 2953 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta);
2964 scroll_info->swap_promises.swap(swap_promises_for_main_thread_scroll_update_);
2965 2954
2966 return scroll_info.Pass(); 2955 return scroll_info.Pass();
2967 } 2956 }
2968 2957
2969 void LayerTreeHostImpl::SetFullRootLayerDamage() { 2958 void LayerTreeHostImpl::SetFullRootLayerDamage() {
2970 SetViewportDamage(gfx::Rect(DrawViewportSize())); 2959 SetViewportDamage(gfx::Rect(DrawViewportSize()));
2971 } 2960 }
2972 2961
2973 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) { 2962 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) {
2974 DCHECK(on_demand_task_graph_runner_); 2963 DCHECK(on_demand_task_graph_runner_);
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
3368 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) { 3357 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) {
3369 swap_promise_monitor_.erase(monitor); 3358 swap_promise_monitor_.erase(monitor);
3370 } 3359 }
3371 3360
3372 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() { 3361 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
3373 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin(); 3362 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3374 for (; it != swap_promise_monitor_.end(); it++) 3363 for (; it != swap_promise_monitor_.end(); it++)
3375 (*it)->OnSetNeedsRedrawOnImpl(); 3364 (*it)->OnSetNeedsRedrawOnImpl();
3376 } 3365 }
3377 3366
3378 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfForwardingToMainThread() {
3379 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3380 for (; it != swap_promise_monitor_.end(); it++)
3381 (*it)->OnForwardScrollUpdateToMainThreadOnImpl();
3382 }
3383
3384 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) { 3367 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) {
3385 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) == 3368 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) ==
3386 picture_layers_.end()); 3369 picture_layers_.end());
3387 picture_layers_.push_back(layer); 3370 picture_layers_.push_back(layer);
3388 } 3371 }
3389 3372
3390 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) { 3373 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
3391 std::vector<PictureLayerImpl*>::iterator it = 3374 std::vector<PictureLayerImpl*>::iterator it =
3392 std::find(picture_layers_.begin(), picture_layers_.end(), layer); 3375 std::find(picture_layers_.begin(), picture_layers_.end(), layer);
3393 DCHECK(it != picture_layers_.end()); 3376 DCHECK(it != picture_layers_.end());
3394 picture_layers_.erase(it); 3377 picture_layers_.erase(it);
3395 } 3378 }
3396 3379
3397 } // namespace cc 3380 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698